Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: change stats label from unique to total #2337

Merged

Conversation

rekt-hard
Copy link
Contributor

❤️ Thank you for your contribution!

Description

closes https://github.com/zenodo/rdm-project/issues/199
Change stats label from unique to total

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR suffers of the same issue of variable interpolation in the translated string (more info here https://inveniordm.docs.cern.ch/develop/howtos/i18n/#javascript) but there is no easy fix I think. Merging it like this for the time being

@ntarocco ntarocco merged commit 999421f into inveniosoftware:master Aug 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants